Skip to content

[CSL-2197] Add quiz_session_id, quiz_version_id #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 4, 2023
Merged

[CSL-2197] Add quiz_session_id, quiz_version_id #245

merged 11 commits into from
Apr 4, 2023

Conversation

@stanlp1
Copy link
Contributor

@stanlp1 stanlp1 commented Mar 27, 2023

No description provided.

@stanlp1 stanlp1 requested a review from a team March 27, 2023 22:44
esezen
esezen reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks for working on this. Left some comments, let me know what you think

@stanlp1 stanlp1 requested a review from esezen March 29, 2023 17:17
esezen
esezen approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. This is looking great!

@esezen esezen mentioned this pull request Mar 30, 2023
Merged
@esezen esezen requested a review from jjl014 March 30, 2023 18:27
jjl014
jjl014 reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This is looking pretty good to me.

I left a couple comments in regards to updating some of the tests and keeping others that we deleted (which might be blocked by the quizzes team).

@stanlp1 stanlp1 requested a review from jjl014 April 3, 2023 16:58
jjl014
jjl014 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making these changes! 🚀

@jjl014
Copy link
Contributor

jjl014 commented Apr 3, 2023

@stanlp1 Looks like there's some merge conflicts. We can merge/publish after we resolve them 👍

@stanlp1
Copy link
Contributor Author

stanlp1 commented Apr 4, 2023

Looks like we're good

@esezen esezen merged commit 9565be2 into master Apr 4, 2023
@esezen esezen deleted the csl-2197-client-javascript-add-support-for branch April 4, 2023 16:38
@stanlp1 stanlp1 mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esezen esezen esezen approved these changes

@jjl014 jjl014 jjl014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stanlp1 @jjl014 @esezen